chore(enable sonarlint deprecation rule + fixes) #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e waitForNavigation with waitForURL
|
it seems that there are issues with appending the accepted/refused cookie's header... from what I can tell, this seems to be some issue with remix's implementation of the |
… plain objects otherwise" This reverts commit 62aea26.
pgurusinga
reviewed
Nov 20, 2024
pgurusinga
approved these changes
Nov 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the no-alphabetical-sort sonarjs eslint rule, and turns off the sonarjs/deprecation rule (for now, until remix upgrades to react router v7 and we turn Single Fetch on - see issue listed below